Skip to content

Conversation

marcomangano
Copy link
Contributor

Purpose

This PR updates the minimum packages requirements and version of Niceplots based on this GitHub issue

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@marcomangano marcomangano requested a review from a team as a code owner February 5, 2025 00:45
@marcomangano marcomangano requested a review from eirikurj February 5, 2025 00:45
@marcomangano
Copy link
Contributor Author

The tests are failing because of an issue with downloading/opening the font .zip file

@A-CGray
Copy link
Member

A-CGray commented Feb 7, 2025

Not sure what's going on with the prompt font download, the link works fine if I manually follow it. Any ideas @eytanadler ?

@eytanadler
Copy link
Collaborator

If I follow the same steps in the Prompt install in my terminal locally I get the same error. I think it's related to this issue: google/fonts#7481.

@A-CGray
Copy link
Member

A-CGray commented Feb 28, 2025

#43 will fix this

@A-CGray
Copy link
Member

A-CGray commented Mar 5, 2025

Increasing this to a minor version bump since #43 adds functionality to niceplots

@A-CGray A-CGray self-requested a review March 5, 2025 20:13
@A-CGray A-CGray merged commit a0b7195 into main Mar 19, 2025
17 checks passed
@A-CGray A-CGray deleted the marcomangano-patch-1 branch March 19, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants