Skip to content

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Aug 20, 2025

Purpose

One of the labels in the doumont style demos was intersecting with the y axis, so I made the axes wider.

Before:
image

After:
image

For some reason this is only an issue on the website, not when you run the examples locally.

I also updated the versions of python, numpy, and matplotlib that we test with.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner August 20, 2025 15:56
@A-CGray A-CGray requested a review from eirikurj August 20, 2025 15:56
@marcomangano
Copy link
Contributor

marcomangano commented Aug 20, 2025

For some reason a test is failing because matplotlib is forcing the install of numpy 2, despite numpy==1.23.* being installed right before satisfies the matplotlib 3.6 dependencies constraints (wants numpy >= 1.19)

Successfully installed numpy-1.23.5
Collecting matplotlib==3.6.*
  Downloading matplotlib-3.6.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (6.8 kB)
Collecting contourpy>=1.0.1 (from matplotlib==3.6.*)
  Downloading contourpy-1.3.3-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl.metadata (5.5 kB)
Collecting cycler>=0.10 (from matplotlib==3.6.*)
  Downloading cycler-0.12.1-py3-none-any.whl.metadata (3.8 kB)
Collecting fonttools>=4.22.0 (from matplotlib==3.6.*)
  Downloading fonttools-4.59.1-cp311-cp311-manylinux2014_x86_64.manylinux_2_17_x86_64.whl.metadata (108 kB)
Collecting kiwisolver>=1.0.1 (from matplotlib==3.6.*)
  Downloading kiwisolver-1.4.9-cp311-cp311-manylinux2014_x86_64.manylinux_2_17_x86_64.whl.metadata (6.3 kB)
**Requirement already satisfied: numpy>=1.19** in /opt/hostedtoolcache/Python/3.11.13/x64/lib/python3.11/site-packages (from matplotlib==3.6.*) (1.23.5)
Collecting packaging>=20.0 (from matplotlib==3.6.*)
  Downloading packaging-25.0-py3-none-any.whl.metadata (3.3 kB)
Collecting pillow>=6.2.0 (from matplotlib==3.6.*)
  Downloading pillow-11.3.0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl.metadata (9.0 kB)
Collecting pyparsing>=2.2.1 (from matplotlib==3.6.*)
  Downloading pyparsing-3.2.3-py3-none-any.whl.metadata (5.0 kB)
Collecting python-dateutil>=2.7 (from matplotlib==3.6.*)
  Downloading python_dateutil-2.9.0.post0-py2.py3-none-any.whl.metadata (8.4 kB)
**Collecting numpy>=1.19 (from matplotlib==3.6.*)
  Downloading numpy-2.3.2-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl.metadata (62 kB)**

@A-CGray A-CGray requested a review from marcomangano August 28, 2025 20:13
@A-CGray
Copy link
Member Author

A-CGray commented Sep 18, 2025

bump @marcomangano

@A-CGray A-CGray merged commit 16fc375 into main Sep 19, 2025
17 checks passed
@A-CGray A-CGray deleted the styleDemoUpdate branch September 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants