Skip to content

Commit

Permalink
Stop enforcing elfprooef algorithm for Dutch IBANS
Browse files Browse the repository at this point in the history
  • Loading branch information
mdomke committed Jun 4, 2024
1 parent c467335 commit 3de4b0d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ Changelog

Versions follow `CalVer <http://www.calver.org/>`_ with the scheme ``YY.0M.Micro``.

`2024.06.0`_ - 2024/06/04
-------------------------
Changed
~~~~~~~
* Stop using the "elfprooef" algorithm when validating Dutch IBANs, since the administrative
authority says it should not be checked any more.


`2024.05.4`_ - 2024/05/25
-------------------------
Added
Expand Down Expand Up @@ -640,6 +648,7 @@ Added
* Added :attr:`.BIC.country` and :attr:`.IBAN.country`.


.. _2024.06.0: https://github.com/mdomke/schwifty/compare/2024.05.4...2024.06.0
.. _2024.05.4: https://github.com/mdomke/schwifty/compare/2024.05.3...2024.05.4
.. _2024.05.3: https://github.com/mdomke/schwifty/compare/2024.05.2...2024.05.3
.. _2024.05.2: https://github.com/mdomke/schwifty/compare/2024.05.1...2024.05.2
Expand Down
7 changes: 6 additions & 1 deletion schwifty/checksum/netherlands.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@
from schwifty.domain import Component


@checksum.register("NL")
class DefaultAlgorithm(checksum.Algorithm):
"""This algorithm is not used anymore for Dutch IBANs and is therefore not registered anymore.
See https://www.betaalvereniging.nl/betaalproducten-en-diensten/iban/ibannext/ for more
information
"""

name = "default"
accepts: ClassVar[list[Component]] = [Component.ACCOUNT_CODE]

Expand Down
4 changes: 0 additions & 4 deletions tests/test_checksum.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,5 @@ def test_belgium_checksum_checksum_edge_case() -> None:
assert algorithms["BE:default"].validate(["050", "0000177"], "97") is True


def test_netherlands_checksum() -> None:
assert algorithms["NL:default"].validate(["0417164300"], "") is True


def test_norway_checksum_checksum_edge_case() -> None:
assert algorithms["NO:default"].validate(["6042", "143964"], "0") is True

0 comments on commit 3de4b0d

Please sign in to comment.