Pad with free #66
Merged
Pad with free #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsteele
reviewed
Jul 16, 2025
src/internal/consts.rs
Outdated
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq)] | ||
| pub(crate) enum Ty { |
There was a problem hiding this comment.
Short for Type. Muscle memory kicked in because type is a reserved keyword, commonly abbreviated to ty, but doesn't have the same issue when uppercased as Type. Can change.
Some cfbs manage to mislabel their sectors so badly that their DIFAT chain mentions sectors that are labeled FREE in the FAT. When the trimming of the FAT strips those sectors from the end of the FAT, these will error with 'Malformed FAT (FAT has 14976 entries, but DIFAT lists 14976 as a DIFAT sector)' By ensuring the FAT is always padded with FREE_SECTOR to the end of the file, fn validate() has a chance to correct the mislabeled sectors.
|
Rebased on master |
Merged
mdsteele
added a commit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into errors of the form
and tracked it down to a
FREE_SECTORat the end of the file. When theFREE_SECTORare stripped from the end of the FAT, and the DIFAT points to that sector, then the call tofn validatewill not have a chance to try and fix the .cfb.With this fix the files that had the error now succeed.
I may try and come up with a synthetic version of those files, but I'm making this PR without them for now. I also added some of the code I wrote to debug this.