-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ios): update feature documentation #1863
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -7,5 +7,11 @@ | |||
All the features supported by the Measure SDK are listed below. | |||
|
|||
* [App launch](features/feature_app_launch.md) | |||
* [Crash tracking](features/feature_crash_tracking.md) | |||
* [Network monitoring](features/feature_network_monitoring.md) | |||
* [Network changes](features/feature_network_changes.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the network changes documentation we should clearly mention that this is only available upto iOS 16.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also consider removing it if this will no longer be available in fufture and if there are no alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a issue for this here.
@@ -7,5 +7,11 @@ | |||
All the features supported by the Measure SDK are listed below. | |||
|
|||
* [App launch](features/feature_app_launch.md) | |||
* [Crash tracking](features/feature_crash_tracking.md) | |||
* [Network monitoring](features/feature_network_monitoring.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Give a more detailed usage example to use
NetworkInterceptor
. - Consider renaming the
NetworkInterceptor
toMsrNetworkInterceptor
. - Anything that requires manual setup must also be documented in the main
README.md
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a issue for this here.
75644e8
to
6c160e6
Compare
6c160e6
to
9e9d67c
Compare
9e9d67c
to
3e4d09c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add iOS to table of contents here: https://github.com/measure-sh/measure/tree/ios-documentation/docs
Added some more comments, can merge after they are resolved.
|
||
| Screenshot | Layout snapshot | | ||
|-------------------------------------------------------|--------------------------------------------------| | ||
|  |  | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Task Info](https://web.mit.edu/darwin/src/modules/xnu/osfmk/man/task_info.html) | ||
[iOS Memory Deep Dive](https://developer.apple.com/videos/play/wwdc2018/416/) | ||
[Apple Developer Forum Thread](https://developer.apple.com/forums/thread/105088) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
iOS documentation added
Related issue
Closes #1583