Add relationship start and end dates to the relationship processor #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks helpful. Any chance of it being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds relationship start and end date fields to the relationship processor, as requested in issue #166.
Before
The relationship processor did not include fields for the relationship start and end dates.
After
The relationship processor includes optional fields for the relationship start and end dates. These are dropdowns which can be used to select a Field or a System Tag.
Technical Details
I have employed patterns used by other processors to iterate over the fields.
Comments
If no start or end date is supplied, then the processor's behaviour is unchanged. If a single relationship of the specified type between the specified contacts already exists, then its start and/or end dates will be updated. If multiple matching relationships already exist, then the processor will do nothing.