Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to change status of related contribution when order status is changed to Completed to Cancelled #32

Open
monishdeb opened this issue Jan 19, 2021 · 6 comments

Comments

@monishdeb
Copy link
Contributor

Change status of any existing completed order to 'Cancelled'. It doesn't able to update the linked Contribution status
to 'Cancelled' and on debugging the error message here I got :

Expected one FinancialItem but found 0

It seems that there is no linked FinancialItem with the contribution's line-item(s), and thus it causes an issue on order status change.

@monishdeb monishdeb changed the title Fail to change status from related contribution when order status is changed to Completed to Cancelled Fail to change status of related contribution when order status is changed to Completed to Cancelled Jan 19, 2021
@JoeMurray
Copy link
Contributor

JMA will be submitting a fix for this shortly.

@agileware-justin
Copy link

@JoeMurray might want to check #33

@monishdeb
Copy link
Contributor Author

@agileware-justin thanks for the patch, will review it shortly and provide my feedback on PR itself.

@agileware-justin
Copy link

@monishdeb there is also #34 and #35 as well for review if you have time.

@monishdeb
Copy link
Contributor Author

Sure will do 👍

@agileware-justin
Copy link

Change status of any existing completed order to 'Cancelled'. It doesn't able to update the linked Contribution status
to 'Cancelled

@monishdeb this works from my testing, suggest you confirm same and if so, then mark this issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants