Refactoring code using urllib3._collections

minet/pycurl.py

@@ -1,5 +1,5 @@
 from typing import Optional, Dict, List, Union
-from minet.types import AnyTimeout, RedirectionStack, Redirection, HTTPHeaderDict
+from minet.types import AnyTimeout, RedirectionStack, Redirection
 
 import pycurl
 import certifi
@@ -10,6 +10,7 @@
 from urllib3 import Timeout
 from urllib.parse import urljoin
 from urllib3.util.url import parse_url
+from urllib3._collections import HTTPHeaderDict
 
 from minet.constants import REDIRECT_STATUSES
 from minet.exceptions import (

minet/types.py

@@ -2,7 +2,6 @@
 from typing import Union, List, Optional, Literal
 from os import PathLike
 from io import FileIO
-from bs4 import BeautifulSoup
 from urllib3 import Timeout
 from ebbe import format_repr
 
@@ -17,12 +16,6 @@
 else:
     from typing_extensions import TypedDict, Required, NotRequired, Unpack
 
-# Useful conditional imports
-try:
-    from urllib3 import HTTPHeaderDict
-except ImportError:
-    from urllib3._collections import HTTPHeaderDict
-
 # Useful Any types
 AnyPath = Union[str, PathLike]
 AnyFileTarget = Union[AnyPath, FileIO]

minet/web.py

@@ -16,7 +16,7 @@
     Dict,
     Container,
 )
-from minet.types import AnyTimeout, Redirection, RedirectionStack, HTTPHeaderDict
+from minet.types import AnyTimeout, Redirection, RedirectionStack
 
 import re
 import cgi
@@ -40,6 +40,7 @@
 from urllib.request import Request
 from urllib3.util.ssl_ import create_urllib3_context
 from urllib3.util.request import ACCEPT_ENCODING
+from urllib3._collections import HTTPHeaderDict
 from ebbe import rcompose, noop, format_filesize, format_repr
 from tenacity import (
     Retrying,