Skip to content

Commit

Permalink
Adding timeout kwarg to crawl_command
Browse files Browse the repository at this point in the history
Fix #919
  • Loading branch information
Yomguithereal committed Dec 20, 2023
1 parent 34b407e commit 0d7f03c
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions minet/cli/crawl/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def crawl_command(
default_retries: Optional[int] = None,
force_spoof_user_agent: Optional[bool] = None,
force_stateful_redirects: Optional[bool] = None,
timeout: bool = True,
default_timeout: Optional[float] = None,
default_connect_timeout: Optional[float] = None,
):
Expand Down Expand Up @@ -241,11 +242,16 @@ def set_default_value(k, v):
if default_retries is not None:
set_default_value("retries", default_retries)

if default_timeout is not None:
set_default_value("timeout", default_timeout)
if not timeout:
del arguments_dict["timeout"]
del arguments_dict["connect_timeout"]

if default_connect_timeout is not None:
set_default_value("connect_timeout", default_connect_timeout)
else:
if default_timeout is not None:
set_default_value("timeout", default_timeout)

if default_connect_timeout is not None:
set_default_value("connect_timeout", default_connect_timeout)

if force_folder_strategy is not None:
del arguments_dict["folder_strategy"]
Expand Down Expand Up @@ -337,9 +343,10 @@ def wrapped_resolve(cli_args):
if resolve is not None:
resolve(cli_args)

cli_args.timeout = Timeout(
connect=cli_args.connect_timeout, total=cli_args.timeout
)
if timeout:
cli_args.timeout = Timeout(
connect=cli_args.connect_timeout, total=cli_args.timeout
)

# --sqlar disables --compress-on-disk
if cli_args.sqlar:
Expand Down

0 comments on commit 0d7f03c

Please sign in to comment.