Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change certificate-validation record behavior #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

change certificate-validation record behavior #3

wants to merge 3 commits into from

Conversation

frozeneyemr
Copy link

change the resource "aws_route53_record" "record" - for_each behavior.

Tested as cert module only and also as embedded module in redirect-module

Please be sure to change the dependencies in your other modules where this module is embedded.

@frozeneyemr frozeneyemr mentioned this pull request Oct 26, 2021
Open
kitsunde
kitsunde requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@kitsunde kitsunde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine, just looks like some copy-pasted thing at the end to remove.

main.tf Outdated Show resolved Hide resolved
@frozeneyemr
Copy link
Author

Hi @kitsunde when you will able to merge it?

Thanks!

@kitsunde
Copy link
Member

kitsunde commented Nov 5, 2021

I will do it sometime over the weekend. Sorry got the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunde kitsunde Awaiting requested review from kitsunde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frozeneyemr @kitsunde