Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#9577): clean up and organize page-object files from /common folder #9591

Merged
merged 22 commits into from
Nov 13, 2024
Merged

chore(#9577): clean up and organize page-object files from /common folder #9591

merged 22 commits into from
Nov 13, 2024

Conversation

tatilepizs
Copy link
Contributor

@tatilepizs tatilepizs commented Oct 28, 2024 •
edited
Loading

Description

clean up and organize page-object files from /common folder

#9577

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@tatilepizs tatilepizs linked an issue Oct 28, 2024 that may be closed by this pull request
Clean up and organize page-object files from /common folder #9577
Closed
@tatilepizs tatilepizs marked this pull request as ready for review November 7, 2024 21:41
latin-panda
latin-panda approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ✨ Love seeing a standard across, will make maintenance and debugging easier

tests/e2e/default-mobile/wdio.conf.js Outdated Show resolved Hide resolved
tests/page-objects/default/common/common.wdio.page.js Outdated Show resolved Hide resolved
kapelo
kapelo approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@kapelo kapelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lorerod
Copy link
Contributor

lorerod commented Nov 13, 2024

Hey @tatilepizs, I see that both Jenni and Ani have reviewed this PR, and their feedback has been addressed. I think the coverage looks solid, so I’ll be stepping back. Let me know if you need anything else from my end—great work!

@lorerod lorerod removed their request for review November 13, 2024 17:36
@tatilepizs tatilepizs merged commit b85e1e5 into master Nov 13, 2024
45 checks passed
@tatilepizs tatilepizs deleted the 9577-clean-up-and-organize-page-object-files branch November 13, 2024 20:32
sugat009 pushed a commit that referenced this pull request Nov 18, 2024
@tatilepizs @sugat009
chore(#9577): clean up and organize page-object files from /common fo…
e7e7571 
…lder (#9591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latin-panda latin-panda latin-panda approved these changes

@kapelo kapelo kapelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up and organize page-object files from /common folder
4 participants
@tatilepizs @lorerod @kapelo @latin-panda