Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9604): fix integer validation in sms rules #9608

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix(#9604): fix integer validation in sms rules #9608

merged 2 commits into from
Nov 4, 2024

Conversation

garethbowen
Copy link
Contributor

@garethbowen garethbowen commented Nov 4, 2024 •
edited by github-actions bot
Loading

Description

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@garethbowen garethbowen linked an issue Nov 4, 2024 that may be closed by this pull request
SMS "integer" validation always returns false #9604
Closed
@garethbowen garethbowen requested a review from 1yuv November 4, 2024 10:15
@garethbowen
Copy link
Contributor Author

@1yuv Thanks for finding that! Turns out I broke the integer validation completely. If you have a chance to review this I'll get it backported to 4.14.0 before it's released.

@garethbowen
Copy link
Contributor Author

@dianabarsan I think Yuvraj is on leave. Would you mind reviewing this so I can unblock 4.14.0?

dianabarsan
dianabarsan approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment about a confusing test name.
Wish these had integration tests.

shared-libs/validation/test/validator_functions.js Outdated Show resolved Hide resolved
@garethbowen garethbowen merged commit 63a2660 into master Nov 4, 2024
5 checks passed
@garethbowen garethbowen deleted the 9604-fix-integer-validation branch November 4, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianabarsan dianabarsan dianabarsan approved these changes

@1yuv 1yuv Awaiting requested review from 1yuv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMS "integer" validation always returns false
2 participants
@garethbowen @dianabarsan