Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#9543): flaky e2e test incorrect locale #9611

Merged
merged 20 commits into from
Nov 11, 2024
Merged

chore(#9543): flaky e2e test incorrect locale #9611

merged 20 commits into from
Nov 11, 2024

Conversation

ralfudx
Copy link
Contributor

@ralfudx ralfudx commented Nov 4, 2024 •
edited by github-actions bot
Loading

Description

#9543

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@ralfudx ralfudx self-assigned this Nov 6, 2024
@ralfudx ralfudx linked an issue Nov 6, 2024 that may be closed by this pull request
Flaky e2e test: incorrect-locale has been failing constantly in "after each" hook #9543
Closed
tatilepizs
tatilepizs approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@tatilepizs tatilepizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation @ralfudx

@ralfudx ralfudx merged commit 6fd569a into master Nov 11, 2024
45 checks passed
@ralfudx ralfudx deleted the 9543-flaky-e2e-test-incorrect-locale branch November 11, 2024 15:06
tatilepizs added a commit that referenced this pull request Nov 12, 2024
@tatilepizs
add changes from #9611
739f56d
sugat009 pushed a commit that referenced this pull request Nov 18, 2024
@ralfudx @sugat009
chore(#9543): flaky e2e test incorrect locale (#9611)
d2dc5eb 
Co-authored-by: Rafa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

@kapelo kapelo kapelo approved these changes

@tatilepizs tatilepizs tatilepizs approved these changes

Assignees

@ralfudx ralfudx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky e2e test: incorrect-locale has been failing constantly in "after each" hook
4 participants
@ralfudx @lorerod @kapelo @tatilepizs