feat(#6250): use fetch in couch-request by dianabarsan · Pull Request #9746 · medic/cht-core

dianabarsan · 2025-01-15T16:01:40Z

Description

Removes request-promise-native.

#6250

Code review checklist

UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
Readable: Concise, well named, follows the style guide, documented if necessary.
Documented: Configuration and user documentation on cht-docs
Tested: Unit and/or e2e where appropriate
Internationalised: All user facing text
Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Signed-off-by: Diana Barsan <barsan@medic.org>

- handing server sending JSON headers but no content - double slash paths - from data -> json Signed-off-by: Diana Barsan <barsan@medic.org>

Signed-off-by: Diana Barsan <barsan@medic.org>

-          json: true,
          body: { urns: ['tel:phone1'], text: 'message1', },
-          headers: { Accept: 'application/json', Authorization: 'Token customRapidPro' },
+          headers: { Authorization: 'Token customRapidPro' },


-          json: true,
          body: { urns: ['tel:phone2'], text: 'message2', },
-          headers: { Accept: 'application/json', Authorization: 'Token customRapidPro' },
+          headers: { Authorization: 'Token customRapidPro' },


-          json: true,
          qs: { broadcast: `broadcast${i}` },
-          headers: { Accept: 'application/json', Authorization: 'Token key' },
+          headers: { Authorization: 'Token key' },


-          json: true,
          qs: { broadcast: `ref2` },
-          headers: { Accept: 'application/json', Authorization: 'Token key' },
+          headers: { Authorization: 'Token key' },


-          json: true,
          qs: { broadcast: `ref4` },
-          headers: { Accept: 'application/json', Authorization: 'Token key' },
+          headers: { Authorization: 'Token key' },


          uri: '/api/v2/messages.json',
          qs: { broadcast: `ref1` },
-          headers: { Accept: 'application/json', Authorization: 'Token key' },
+          headers: { Authorization: 'Token key' },


          uri: '/api/v2/messages.json',
          qs: { broadcast: `ref2` },
-          headers: { Accept: 'application/json', Authorization: 'Token key' },
+          headers: { Authorization: 'Token key' },


Signed-off-by: Diana Barsan <barsan@medic.org>

+    await couchRequest.post({
+      url: 'http://a:b@marvel.net:5984/a',
+      auth: { username: 'admin', password: '123456' },
+      headers: { authorization: 'Bearer something' },


+        headers: {
+          accept: 'application/json',
+          'content-type': 'application/json',
+          authorization: 'Bearer something',


dianabarsan · 2025-01-22T06:04:16Z

Hi @jkuester ! Would you mind with some feedback over here? Appreciate it!!!

jkuester · 2025-01-22T19:12:55Z

👍 Will have a look asap, but might not be until Friday.

jkuester

Send it! Just a few minor non-blocking comments.

(Also just have to say that I hate JS. With no type safety this kind of refactor is terrifying. AFICT you caught all the user > username, pass > password, and statusCode > status changes, but it is really hard to tell....)

Signed-off-by: Diana Barsan <barsan@medic.org>

+    const opts = {
+      url: 'http://a:b@marvel.net:5984/a',
+      auth: { username: 'admin', password: '123456' },
+      headers: { authorization: 'Bearer something' },


Signed-off-by: Diana Barsan <barsan@medic.org>

…edic#9746) medic#6250

dianabarsan added 3 commits January 14, 2025 18:15

switches to fetch in couch-request.js

c10ac9d

Signed-off-by: Diana Barsan <barsan@medic.org>

updates unit tests

ee374cb

Signed-off-by: Diana Barsan <barsan@medic.org>

fix linting.

fb696b2

Signed-off-by: Diana Barsan <barsan@medic.org>

github-advanced-security AI found potential problems Jan 15, 2025

View reviewed changes

Comment thread shared-libs/couch-request/test/couch-request.js Fixed

Comment thread shared-libs/couch-request/test/couch-request.js Fixed

dianabarsan added 3 commits January 16, 2025 13:10

fixes api unit tests

9d255ca

Signed-off-by: Diana Barsan <barsan@medic.org>

fixes:

0b8dea9

- handing server sending JSON headers but no content - double slash paths - from data -> json Signed-off-by: Diana Barsan <barsan@medic.org>

fixes rapidpro unit tests

53ed67d

Signed-off-by: Diana Barsan <barsan@medic.org>

github-advanced-security AI found potential problems Jan 18, 2025

View reviewed changes

dianabarsan added 5 commits January 18, 2025 15:00

fix outbound e2e tests

6c29e3f

Signed-off-by: Diana Barsan <barsan@medic.org>

bump test coverage

5584dd4

Signed-off-by: Diana Barsan <barsan@medic.org>

fix unit tests

5cc9eab

Signed-off-by: Diana Barsan <barsan@medic.org>

appease the sonar gods

8c5e8a5

Signed-off-by: Diana Barsan <barsan@medic.org>

appease the sonar gods

d1e04d4

Signed-off-by: Diana Barsan <barsan@medic.org>

dianabarsan marked this pull request as ready for review January 21, 2025 05:36

make headers lower case

1a68bef

Signed-off-by: Diana Barsan <barsan@medic.org>

github-advanced-security AI found potential problems Jan 21, 2025

View reviewed changes

dianabarsan requested a review from jkuester January 22, 2025 06:03

jkuester approved these changes Jan 24, 2025

View reviewed changes

Comment thread shared-libs/couch-request/src/couch-request.js

Comment thread shared-libs/couch-request/src/couch-request.js Outdated

Comment thread shared-libs/couch-request/src/couch-request.js Outdated

Comment thread api/src/auth.js Outdated

dianabarsan added 2 commits January 27, 2025 15:58

throw error when passed conflicting authentication

7435e79

Signed-off-by: Diana Barsan <barsan@medic.org>

code review feedback

ea8650b

Signed-off-by: Diana Barsan <barsan@medic.org>

github-advanced-security AI found potential problems Jan 27, 2025

View reviewed changes

switch to buffer.from instead of btoa/atob

8b443d2

Signed-off-by: Diana Barsan <barsan@medic.org>

dianabarsan merged commit 2c5a640 into master Jan 27, 2025

dianabarsan deleted the 6250-use-fetch-in-couch-request branch January 27, 2025 16:07

ShaunKrog pushed a commit to ShaunKrog/cht-core that referenced this pull request May 15, 2025

feat(medic#6250): removes request-promise-native in favor of fetch (m…

03ed75a

…edic#9746) medic#6250

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(#6250): use fetch in couch-request#9746

feat(#6250): use fetch in couch-request#9746
dianabarsan merged 15 commits intomasterfrom
6250-use-fetch-in-couch-request

dianabarsan commented Jan 15, 2025 •

edited by github-actions Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

dianabarsan commented Jan 22, 2025

Uh oh!

jkuester commented Jan 22, 2025

Uh oh!

jkuester left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dianabarsan commented Jan 15, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code review checklist

Compose URLs

License

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

dianabarsan commented Jan 22, 2025

Uh oh!

jkuester commented Jan 22, 2025

Uh oh!

jkuester left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dianabarsan commented Jan 15, 2025 •

edited by github-actions Bot

Loading

jkuester left a comment •

edited

Loading