Update Makefile #151
Update Makefile #151
Conversation
Currently the release document created by CI uses github.ref_name in
place of the release version, but since we are not running this job on
tag creation anymore, this variable has the name of the branch instead
than the tag.
This change replaced {{github.ref_name}} with v{{inputs.version}}, which
contains the proper tag version.
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clobrano
force-pushed
the
add-mandatory-annotations-to-okd-bundle
branch
from
933e6a1
to
3e1ab52
Compare
Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
add-mandatory-annotations-to-okd-bundle
branch
from
3e1ab52
to
ff0b132
Compare
|
/test 4.16-openshift-e2e |
| @@ -1,12 +1,12 @@ | |||
| module github.com/medik8s/fence-agents-remediation | |||
|
|
|||
| go 1.20 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Update the Golang version in https://github.com/medik8s/fence-agents-remediation/blob/main/.ci-operator.yaml as well for OCP CI
| .PHONY: add-ocp-annotations | ||
| add-ocp-annotations: yq ## Add OCP annotations |
There was a problem hiding this comment.
Is there a reason to add it here (upstream) and not just downstream?
There was a problem hiding this comment.
OKD is also verifying their existence.
medik8s/self-node-remediation#221
I will update the commit message
|
Dropping last commit, as it is already included in #150 |
|
superseded by #152 |
Why we need this PR
The current Makefile needs update for
adding the mandatory annotation, I also noted an issue in CI which I decided to fix here, see the first change in the next section.
Changes made
Which issue(s) this PR fixes
Test plan