Support Only reboot Action #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E test is expected to fail as we don't support |
razo7
changed the title
razo7
changed the title
slintes
requested changes
Jun 15, 2023
Merged
mshitrit
reviewed
Jun 28, 2023
mshitrit
reviewed
Jun 28, 2023
mshitrit
reviewed
Jun 28, 2023
mshitrit
reviewed
Jun 28, 2023
slintes
reviewed
Jun 28, 2023
|
/retest |
Raise a warning when a different action was asked, and either way try to reboot the node
Check on Reconcile that stdout from running the FA equlas to SuccessFAResponse
We log an error prior to every time that the function returns an error
razo7
force-pushed
the
verify-cli-output
branch
2 times, most recently
from
3c0722d
to
a5f4761
Compare
|
/retest |
mshitrit
reviewed
Jul 26, 2023
Limit the usage of FAs to reboot action only
|
/lgtm |
|
/unhold |
slintes
approved these changes
Jul 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support only
rebootaction - we build the FA command with reboot action, when--actionequals to reboot or this attribute is missing (since reboot is the default action), otherwise we return an error and end reconcileECOPROJECT-1323
EDIT: Another valid action use case could be the off which ensure fencing, just without recovering the node. When then the admin/user will be responsible to turn the node on (or to recover the node) after a possible further investigation.