Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing metadata dependency to ocp bundle #327

Merged

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented May 8, 2024

Why we need this PR

The OCP bundle is created from scratch, which means it deletes the bundle folder previously created by bundle-base target, together with the metadata/dependency.yaml

Changes made

Ensure that the OCP bundle contains the metadata/dependency.yaml

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1981

Test plan

  • Delete the bundle folder
  • make bundle-ocp
  • verify the file bundle/metadata/dependency.yaml exists and matches config/metadata/dependency.yaml

Ensure that the OCP bundle, which creates the bundle folder from
scratch, contains the metadata/dependency.yaml

Signed-off-by: Carlo Lobrano <[email protected]>
Copy link
Contributor

openshift-ci bot commented May 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano marked this pull request as ready for review May 8, 2024 09:14
@openshift-ci openshift-ci bot requested review from razo7 and slintes May 8, 2024 09:14
@slintes
Copy link
Member

slintes commented May 8, 2024

/retest

@clobrano clobrano merged commit 9d59a03 into medik8s:main May 8, 2024
18 checks passed
@clobrano clobrano deleted the fix-missing-metadata-dependency-ocp-bundle-0 branch May 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants