Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #305

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Misc fixes #305

merged 6 commits into from
Jan 18, 2023

Conversation

biolds
Copy link
Contributor

@biolds biolds commented Jan 15, 2023

No description provided.

@meeb
Copy link
Owner

meeb commented Jan 16, 2023 •
edited
Loading

de1a51a - this will break quite a lot of the time. The /@name may not just be a channel, but also a user page or a playlist or some other sort of meta-page. Also the tests are now failing for some reason. Edit: forgot to say thanks, rest of the changes look good!

@biolds
Copy link
Contributor Author

biolds commented Jan 17, 2023

I've moved the commit to a separate PR, #306

@biolds biolds mentioned this pull request Jan 17, 2023
Open
@meeb
Copy link
Owner

meeb commented Jan 17, 2023

Nice, thanks. Can you confirm make test to run the tests works for you with this patch set? The automated tests are failing.

@biolds
Copy link
Contributor Author

biolds commented Jan 17, 2023

Yes, I'll have a look at it this evening, looks like it's not trivial.

@biolds
Copy link
Contributor Author

biolds commented Jan 17, 2023

Fixed

@meeb
Copy link
Owner

meeb commented Jan 18, 2023

Looks good, thanks!

@meeb meeb merged commit f9dfffe into meeb:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biolds @meeb