Only add/remove to chain when options change#1
Merged
gustavolobo merged 1 commit intomeetcleo:masterfrom Mar 10, 2020
Merged
Conversation
There's no reason to add/remove the middleware from the middleware chain everytime a sidekiq job runs. Only do it when the options change. Fixes StatusPage#7
gustavolobo
requested review from
AgentAntelope,
GeorgeA93,
h-lame,
joshuafleck and
mijoharas
h-lame
approved these changes
Mar 9, 2020
h-lame
left a comment
h-lame
left a comment
There was a problem hiding this comment.
It'd be useful to include the reference to the PR on upstream that this commit came from: StatusPage#8. Perhaps this comment is enough to achieve that though 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to add/remove the middleware from the middleware
chain everytime a sidekiq job runs. Only do it when the options change.
Fixes StatusPage#7