-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create two different libraries: heed and heedx #51
Comments
Would indeed be cleaner with separate crates for them I think, features don't work that well for mutually exclusive stuff. One could have a deep transitive dependency that brings in |
When I come to think about it, from a maintenance point of view, providing two back-ends in one repository seems like a liability (burden) to me, regardless of the mechanics. It would be a great loss for the MeiliSearch being the main driver for this project and it not using Consider how the issue tracker for Heed would look in a future where |
Reviving this issue because I would like to create two crates. One of the crate is using The one using fn get<'txn>(&Database, rtxn: &'txn mut RoTxn, key: &'_ [u8]) -> &'txn [u8]; |
As a Reddit user pointed using a feature flag to make heed work with weither LMDB or MDBX is not the best way to do so.
I did this because it was the easiest way to keep the same code base and only tune some functions.
Recently I found a potential alternative to publish two libraries with two different but keep the same code base.
I am here to mentor anyone who is interrested in helping me fixing this issue, and if someone would like to take a look of where the action takes place, he/she can look at the mdb/mod.rs file, this is, in part, where changes will be make.
The text was updated successfully, but these errors were encountered: