-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mdbx support #125
Merged
Merged
Remove mdbx support #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
previously approved these changes
Mar 1, 2022
bors merge |
Kerollmops
force-pushed
the
remove-mdbx-support
branch
from
March 2, 2022 13:06
87b423a
to
5656bfe
Compare
Kerollmops
force-pushed
the
remove-mdbx-support
branch
from
March 2, 2022 13:39
2d4373a
to
dd8304f
Compare
Kerollmops
force-pushed
the
remove-mdbx-support
branch
from
March 2, 2022 14:22
f05e326
to
cc590a7
Compare
MarinPostma
approved these changes
Mar 8, 2022
May I ask what is the reason for removing mdbx support? |
Indeed, I should have explained (I thought I did) but the list of open issues explain that by themselves.
|
Thanks for clearing that up, makes sense! |
By the way, the description of the repo still mentions mdbx :) |
Thank you very much, fixed! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes every reference to the MDBX database, removing its support by the same, and updates the CI to only check the LMDB compilation.