Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mdbx support #125

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Remove mdbx support #125

merged 2 commits into from
Mar 8, 2022

Conversation

Kerollmops
Copy link
Member

This PR removes every reference to the MDBX database, removing its support by the same, and updates the CI to only check the LMDB compilation.

MarinPostma
MarinPostma previously approved these changes Mar 1, 2022
@Kerollmops
Copy link
Member Author

bors merge

@Kerollmops Kerollmops merged commit da4b8f4 into main Mar 8, 2022
@Kerollmops Kerollmops deleted the remove-mdbx-support branch March 8, 2022 16:10
@dvic
Copy link

dvic commented Apr 28, 2022

May I ask what is the reason for removing mdbx support?

@Kerollmops
Copy link
Member Author

Kerollmops commented Apr 28, 2022

Indeed, I should have explained (I thought I did) but the list of open issues explain that by themselves.

  • I was not able to compile MDBX on Windows ad didn't have this time to debug.
  • It was making the code base more complex and less Rust idiomatic.
  • We were not using MDBX and only LMDB for Meilisearch, nobody helped me fix it so I removed the support of it.

@dvic
Copy link

dvic commented Apr 28, 2022

Thanks for clearing that up, makes sense!

@dvic
Copy link

dvic commented Apr 30, 2022

By the way, the description of the repo still mentions mdbx :)

@Kerollmops
Copy link
Member Author

Thank you very much, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants