Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the POSIX semaphore feature from LMDB #140

Closed
wants to merge 2 commits into from
Closed

Add the POSIX semaphore feature from LMDB #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b827009
fix: add posix semaphore support
GregoryConrad Dec 24, 2022
3bc0ffe
fix: remove posix-sem as default feature
GregoryConrad Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions heed/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ default = ["serde", "serde-bincode", "serde-json"]
# a read-only transaction from multiple threads at the same time.
sync-read-txn = []

# Whether to tell LMDB to use POSIX semaphores during compilation
# (instead of System V semaphores).
# POSIX semaphores are required for Apple's App Sandbox on iOS & macOS,
# and are possibly faster and more appropriate for single-process use.
posix-sem = ["lmdb-rkv-sys/posix-sem"]
Comment on lines +42 to +46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to change the documentation a little bit here? Could you add a link to this section in the doc, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I am going to have to recreate the PR because changing the base didn't work as I wanted. Will update the docs in the new PR.


# Enable the serde en/decoders for bincode or serde_json
serde-bincode = ["heed-types/serde", "heed-types/bincode"]
serde-json = ["heed-types/serde", "heed-types/serde_json"]
Expand Down