Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add POSIX semaphores Cargo feature #142

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Add POSIX semaphores Cargo feature #142

merged 1 commit into from
Jan 5, 2023

Conversation

GregoryConrad
Copy link
Contributor

Copied from #140:

Before looking at this PR, please see meilisearch/lmdb-rs#13. It is required before this PR can be merged.

This PR adds LMDB's POSIX semaphore feature to heed. This change allows iOS and macOS builds to be compliant with Apple's App Sandbox (necessary for distribution in the App Store), in addition to possible speed improvements brought upon by the POSIX semaphores.

You could investigate using POSIX semaphores within milli/meilisearch as well for the possible speed improvements they bring, but that is outside the scope of this PR.

@GregoryConrad GregoryConrad changed the title feat: add POSIX semaphores Cargo feature Add POSIX semaphores Cargo feature Jan 4, 2023
@GregoryConrad
Copy link
Contributor Author

Although this PR is in the Draft state, it is actually ready to go; just waiting on the PR to lmdb-rs to be merged.

@Kerollmops
Copy link
Member

I just merged meilisearch/lmdb-rs#13, can you please make this one ready for review? 😊

@GregoryConrad GregoryConrad marked this pull request as ready for review January 5, 2023 12:33
@GregoryConrad
Copy link
Contributor Author

GregoryConrad commented Jan 5, 2023 •
edited
Loading

@Kerollmops ready to review!

Kerollmops
Kerollmops approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very and don't worry about the failing tests they are using MDBX which is a C++ nightmare to compile 😅

@Kerollmops Kerollmops merged commit 0ecdbcf into meilisearch:v0.12 Jan 5, 2023
@Kerollmops Kerollmops mentioned this pull request Jan 5, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GregoryConrad @Kerollmops