RwTxn + RoTxn documentation improvement. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnuria
changed the title
Kerollmops
requested changes
Jul 10, 2023
Sure will squash + add co-author-by since you corrected a lot of typo ! |
|
Oh forgot the osx semaphore limitation doing a last minute push. src: #135 (comment) Done |
Should Fix meilisearch#164 * Document error according to mdb_txn_begin documentation. * Document what kind of locks lmdb do arround transactions * Document limitation by design of transactions * Document OSX limitation related to semaphores Thanks to Kerollmops for the typo spotted in review. Co-authored-by: Clément Renault <[email protected]>
Kerollmops
approved these changes
Jul 10, 2023
|
Thank you very much for the documentation ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Following #150, I feel like it was a good idea to document the possibles errors raisable by: http://www.lmdb.tech/doc/group__mdb.html#gad7ea55da06b77513609efebd44b26920
I didn't included
ENOMEMsince there is no variant yet maybe it's an other whole story.