Add federated search #393
Open
Add federated search #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on meilisearch-ruby 0.30 where MeiliSearch was also renamed.
Used this shell command to automatically rename, and then used the git
diff to manually look through and make sure nothing was wrong:
find lib/ -type f -exec sed -i 's/MeiliSearch/Meilisearch/g' {} \;
(of course also ran it for spec/ and playground/ after making sure the
soft deprecation allowed all tests to pass).
Ran into issues with the regular `const_missing` + `const_get`
deprecation having issues with autoload-ed methods. Added a temporary
workaround just for the Rails module. With this workaround there may be
cases where users are not warned for using MeiliSearch, which should be
investigated.
ellnix
force-pushed
the
federated-search
branch
from
f4847d5 to
0a09b55
Compare
ellnix
force-pushed
the
federated-search
branch
from
0a09b55 to
78d662d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 89.19% 90.03% +0.84%
==========================================
Files 13 14 +1
Lines 768 833 +65
==========================================
+ Hits 685 750 +65
Misses 83 83 ☔ View full report in Codecov by Sentry. |
ellnix
force-pushed
the
federated-search
branch
from
78d662d to
1e3c302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Continues on top of #384
Fixes #389
I've got the general idea of the implementation, what's left is:
Ready for review