Add federated search #393
Open
Add federated search #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellnix
force-pushed
the
federated-search
branch
2 times, most recently
from
0a09b55 to
78d662d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 89.56% 90.38% +0.81%
==========================================
Files 13 14 +1
Lines 776 842 +66
==========================================
+ Hits 695 761 +66
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ellnix
force-pushed
the
federated-search
branch
from
78d662d to
1e3c302
Compare
|
My team has been using the forked repo's branch in our staging environment and everything is working smoothly. We will push to prod soon, but would love to see this hit the mainline release pipeline before pulling the trigger in an ideal world. |
|
I will review this after the rebase or the merge of the class name change :) |
ellnix
force-pushed
the
federated-search
branch
from
1e3c302 to
d4080ed
Compare
ellnix
commented
Mar 19, 2025
| @@ -11,23 +12,59 @@ def multi_search(searches) | |||
| normalize(options, index_target) | |||
| end | |||
|
|
|||
| MultiSearchResult.new(searches, client.multi_search(search_parameters)) | |||
| MultiSearchResult.new(searches, client.multi_search(queries: search_parameters)) | |||
There was a problem hiding this comment.
This change is necessary due to this change in ms-ruby: meilisearch/meilisearch-ruby@055f7d0
ellnix
force-pushed
the
federated-search
branch
from
c2ddbab to
af0c198
Compare
No soft deprecation here, since federated search has not been published yet.
ellnix
force-pushed
the
federated-search
branch
from
5a0b981 to
d2ab989
Compare
|
@brunoocasali Rebased and also removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Continues on top of #384
Fixes #389
I've got the general idea of the implementation, what's left is:
Ready for review