Add code sample and tests for rankingScoreThreshold search parameter #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 677 677
=========================================
Hits 677 677 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
curquiza
added
the
maintenance
curquiza
changed the title
curquiza
reviewed
Jul 6, 2024
|
Merge conflict. |
meili-bors bot
added a commit
that referenced
this pull request
Jul 6, 2024
550: Add code sample and tests for rankingScoreThreshold search parameter r=curquiza a=andre-m-dev # Pull Request ## Related issue Fixes #544 ## What does this PR do? rankingScoreThreshold implemented ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Andre <> Co-authored-by: Clémentine <[email protected]>
|
Build failed: |
|
@andre-m-dev sorry, looks like the tests does not pass since I merged your PR for distinct first 😢 Can you fix the tests? |
|
@curquiza should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #544
What does this PR do?
rankingScoreThreshold implemented
PR checklist
Please check if your PR fulfills the following requirements: