fixup! ppx: consistent errors in runtime

melange-community · Oct 8, 2024 · df73c22 · df73c22
1 parent 7837502
commit df73c22
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/ppx/browser/ppx_deriving_json_runtime.ml b/ppx/browser/ppx_deriving_json_runtime.ml
@@ -14,7 +14,10 @@ let of_string s =
       | Some jsexn -> Js.Exn.message jsexn
       | None -> None
     in
-    let msg = Option.value msg ~default:"JSON error" in
+    let msg =
+      (* msg really cannot be None in browser or any sane JS runtime *)
+      Option.value msg ~default:"JSON error"
+    in
     raise (Json_error msg)
 
 exception Of_json_error = Json.Decode.DecodeError