Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx: flatten tuples in poly constructors #27

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

andreypopp
Copy link
Collaborator

We want to flatten the representation of polyvariants with tuple payload
and represent them as [TAG, ARG1, ARG2, ...] instead of [TAG, [ARG1, ARG2, ...]].

Fixes #24

Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, I thought this would be way more invasive than just changing the schema repr

Copy link
Member

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@andreypopp
Copy link
Collaborator Author

Please add a changelog entry.
done

We want to flatten the representation of polyvariants with tuple payload
and represent them as [TAG, ARG1, ARG2, ...] instead of [TAG, [ARG1, ARG2, ...]].

Fixes #24
@jchavarri jchavarri merged commit 08528f6 into main Oct 7, 2024
7 checks passed
@jchavarri jchavarri deleted the ppx-flatten-poly branch October 7, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding of polymorphic variants differs from ppx_deriving_yojson/ppx_yojson_conv
3 participants