ppx: consistent errors in runtime #28
Open
+71
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main thing we fix here is the consistent use of exceptions in native runtime, which used, before this commit either its own Of_json_error or yojson's Type_error. Then there's ``` val of_string : string -> t ``` which is not required by ppx but was introduced so that the runtime modules can function as minimal JSON interfaces usable both in native and browser environments (so called universal workflow). Before this commit the error behaviour was not specified, now we introduce `exception Of_json of string` in both native and browser and make `of_string` raise it in case of invalid JSON.
davesnx
approved these changes
Oct 8, 2024
| let of_string s = Js.Json.parseExn s | ||
| let of_json_error msg = raise @@ Json.Decode.DecodeError msg | ||
|
|
||
| exception Json_error of string |
There was a problem hiding this comment.
no, this is JSON parsing error, not encode
There was a problem hiding this comment.
True, miss-read the code. Parsing_error then? ^^
| | Some jsexn -> Js.Exn.message jsexn | ||
| | None -> None | ||
| in | ||
| let msg = Option.value msg ~default:"JSON error" in |
There was a problem hiding this comment.
I would add a comment here, explaining that Js.Exn.message can't be none in the browser (and probably true in any js environment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing we fix here is the consistent use of exceptions in native runtime, which used, before this commit either its own Of_json_error or yojson's Type_error.
Then there's
which is not required by ppx but was introduced so that the runtime modules can function as minimal JSON interfaces usable both in native and browser environments (so called universal workflow).
Before this commit the error behaviour was not specified, now we introduce
exception Of_json of stringin both native and browser and makeof_stringraise it in case of invalid JSON.Ref: #9