Use deprecate-react-native-prop-types#917
Open
apfritts wants to merge 1 commit intomeliorence:masterfrom
Open
Conversation
|
+1 |
|
Can confirm this branch removes the warnings when I tested. |
|
Last August a similar PR was opened removing React proptypes. I believe this library is no longer being maintained, and has not received any update in over a year. I hope really popular react-native libraries are instead moved over to @react-community to maintain instead. |
|
any chance to get merged? |
|
I think this repo is dead |
|
@bd-arc could you please take a look at this some minutes? Please, consider taking a look at some PRs, or giving some Admin permissions to some trusted users. Thanks! |
irmakcosarsahna
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
What does this PR do?
RN 0.68 has deprecated and will eventually remove
ViewPropTypes(see post). This adds thedeprecated-react-native-prop-typespackage and uses that instead.What testing has been done on this change?
Local testing, to ensure the deprecation warning has been removed.
Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponent