Rework the plugin to be compatible with Gradle's configuration cache #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Merlin <[email protected]>
asserting up-to-dateness exercising configuration cache reuse
Those throw CNFE for japicmp types referenced by user classes declared in build script bodies. Those same use cases work fine if the user classes are declared in say buildSrc, an included build or a plugin artifact. This is a temporary measure until this is investigated.
eskatos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the plugin to work with Gradle's configuration cache for most use cases.
Along the way, introducing cross-gradle-version testing was implemented. Tests running on Gradle >= 7.2 now always run with the configuration cache enabled. The coverage showed that the plugin is broken with Gradle 5.6.x might be related to #36
There are a couple tests that don't pass with the configuration cache enabled. This is due to some classloading issue in CC implementation. Each of these use case works if the user classes aren't in a build script. I think this PR is already a good step, I would like to get it in first then investigate how to fix the issue in
gradle/gradleand then come back here if needed in another PR.