Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from sqlalchemy to peewee #1797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

07pepa
Copy link

@07pepa 07pepa commented Sep 3, 2024

Description

migrated to peewee to allow multiple database backends and some handy housekeeping stuff

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

with existing test migrating iternals so existing test should be enough

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass in ci/cd using https://github.com/nektos/act

Maintainer Checklist

  • Made sure Checks passed

What should be done

have test with peewee suported databases in matrix and test with each database it works

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants