Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepinfra Embedder #1856

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

PranavPuranik
Copy link
Contributor

@PranavPuranik PranavPuranik commented Sep 11, 2024

Description

PRs getting too big, let's spit it into embedder and llm. This one is for embedder.

Added first embedder test 🎉

Fixes half #1813

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script

config used on readme examples.

    "embedder": {
        "provider": "deepinfra",
        "config": {
            "api_key": "api-key",
            "openai_base_url": "https://api.deepinfra.com/v1/openai",
            "model": "BAAI/bge-large-en-v1.5",
            "embedding_dims": 1024,
            "encoding_format": "float"
        }
    },

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@PranavPuranik
Copy link
Contributor Author

Added bug report for openai because of inconsistent documentation and codebase - https://community.openai.com/t/embedder-encoding-format-default-is-base64-not-float/932616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants