Skip to content

Conversation

@gitbuda
Copy link
Member

@gitbuda gitbuda commented Apr 27, 2025

The main challenge with the HA cluster upgrade tests is that there are multiple different things to wait for (helm, port-forward, data/coordinator getting ready) -> it gets very complex very quickly.

v3.4

NEXT >> #643

@gitbuda
Copy link
Member Author

gitbuda commented Apr 27, 2025

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@sonarqubecloud
Copy link

@coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gitbuda gitbuda changed the title Add v3.3 smoke test updates Add v3.4 smoke test updates Jun 8, 2025
@gitbuda gitbuda changed the title Add v3.4 smoke test updates Add v3.5 smoke test updates Jul 2, 2025
@Josipmrden Josipmrden changed the title Add v3.5 smoke test updates Add v3.4 smoke test updates Jul 2, 2025
@Josipmrden Josipmrden added this to the mage-v3.4.0 milestone Jul 2, 2025
@Josipmrden Josipmrden changed the title Add v3.4 smoke test updates Add v3.5 smoke test updates Jul 2, 2025
@Josipmrden Josipmrden removed this from the mage-v3.4.0 milestone Jul 2, 2025
@Josipmrden Josipmrden changed the title Add v3.5 smoke test updates Add v3.4 smoke test updates Jul 2, 2025
@Josipmrden Josipmrden added this to the mage-v3.4.0 milestone Jul 2, 2025
@gitbuda gitbuda self-assigned this Jul 8, 2025
@gitbuda gitbuda added Docs unnecessary Docs unnecessary type: test Ensuring quality infrastructure labels Jul 8, 2025
@gitbuda gitbuda changed the title Add v3.4 smoke test updates Add v3.4 smoke tests and HA cluster upgrade Jul 20, 2025
@gitbuda gitbuda changed the title Add v3.4 smoke tests and HA cluster upgrade Add v3.4 smoke tests and basic HA cluster upgrade test Jul 20, 2025
@gitbuda gitbuda requested a review from mattkjames7 July 20, 2025 17:24
@gitbuda gitbuda marked this pull request as ready for review July 20, 2025 17:25
@gitbuda gitbuda mentioned this pull request Jul 20, 2025
7 tasks
Copy link
Contributor

@mattkjames7 mattkjames7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

@gitbuda gitbuda enabled auto-merge August 6, 2025 23:08
@gitbuda gitbuda added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit de021ef Aug 7, 2025
9 checks passed
@gitbuda gitbuda deleted the add-v3.3-smoke-test-updates branch August 7, 2025 00:08
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2025
- [x] KShortest
- [x] Text search
- [x] Durability
- [x] User profiles
- [x] memgraph/memgraph#3086
- [x] Leave the code at a better place (mostly replacing `echo "query" |
$MGCONSOLE ...` with `run_next`, etc.)
- [x] Test total execution time

#607 << PREV
NEXT >> #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs unnecessary Docs unnecessary infrastructure type: test Ensuring quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants