Skip to content

Conversation

leo030303
Copy link
Contributor

@leo030303 leo030303 commented Jul 7, 2025

Pulled out type changes from here #1439 into its own PR.

@kkysen kkysen changed the title Changed n_threads and max_frame_delay in Rav1dSettings to be u32 struct Rav1dSettings: change n_threads and max_frame_delay to be u32 Jul 7, 2025
@leo030303 leo030303 requested a review from kkysen July 7, 2025 20:38
@leo030303 leo030303 requested a review from kkysen July 8, 2025 15:42
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes left. Thanks again!

@leo030303 leo030303 requested a review from kkysen July 14, 2025 09:06
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although CI broke again (#1445 should fix it), so I'll wait until that's fixed before merging. Also, #1442 should probably merge first since it's larger and almost done, too, and then you can rebase this PR on top of it.

@kkysen kkysen force-pushed the change-rav1d-settings-types branch from e6b7edd to 4863a8a Compare July 15, 2025 03:45
@kkysen kkysen merged commit ab750d8 into memorysafety:main Jul 15, 2025
28 checks passed
@leo030303 leo030303 deleted the change-rav1d-settings-types branch July 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants