Skip to content

Misc fixes to build dav1d C sources cleanly #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Misc fixes to build dav1d C sources cleanly #1454

merged 1 commit into from
Aug 27, 2025

Conversation

thedataking
Copy link
Collaborator

No description provided.

@thedataking thedataking requested a review from kkysen August 27, 2025 04:44
@djc
Copy link
Collaborator

djc commented Aug 27, 2025

Would be nice to add something to CI to avoid this regressing again.

kkysen
kkysen approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be nice to add something to CI to avoid this regressing again.

When I add the benchmarking script, I might do this. I imagine it'd come pretty naturally in doing that.

@kkysen kkysen merged commit 174df76 into main Aug 27, 2025
28 checks passed
@kkysen kkysen deleted the perl/fix_dav1d_build branch August 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thedataking @djc @kkysen