msac.c: remove fns needed to build dav1d on arm again
#1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added specifically for c2rust previously, but it seems upstream dav1d changes made it unnecessary and break arm dav1d builds.
kkysen
force-pushed
the
kkysen/fix-arm-dav1d-build
branch
from
d6284a5 to
9ecc4e4
Compare
djc
approved these changes
Sep 20, 2025
kkysen
added a commit
that referenced
this pull request
Sep 25, 2025
I deleted these in #1456 to get `dav1d` to compile on aarch64, but now they broke x86_64 builds, so I'm putting them behind `#if ARCH_X86_64`. I'm not exactly sure how to test on 32-bit x86 (I tried `--cross-file=package/crossfiles/i686-linux32.meson` and it worked).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added specifically for c2rust previously, but it seems upstream dav1d changes made it unnecessary and break arm dav1d builds.