`mod lf_apply`: clean up code and use slices instead of raw pointers#728

Merged

fbossen merged 26 commits intomemorysafety:mainfrom

fbossen:cleanup-lf-apply

Mar 7, 2024

Commits on Mar 6, 2024

`fn rav1d_copy_lpf`: use slice instead of pointer for `src_stride`
Frank Bossen
committed
`fn rav1d_copy_lpf`: use slice instead of pointer for `lr_stride`
Frank Bossen
committed
`fn rav1d_copy_lpf`: make `src` parameter a slice reference
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: use slice reference instead of raw pointer
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: clean up loops
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: avoid repeated casts to `usize`
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: clean up masks
Frank Bossen
committed
Use slice instead of raw pointer
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: make `lpf_y` and `lpf_uv` slices
Frank Bossen
committed
Clean up types and casts
Frank Bossen
committed
Use references to `Rav1dDSPContext` object
Frank Bossen
committed
`fn rav1d_loopfilter_sbrow_cols`: pass slices of samples as argument
Frank Bossen
committed
`fn filter_plane_cols_y/uv`: make `dst`/`u`/`v` arguments a slice
Frank Bossen
committed
`lf_apply.rs`: use slices instead of raw pointers
Frank Bossen
committed
`fn backup_lpf`; use slice as parameter
Frank Bossen
committed
Define inner blocks for computation of `p` and `p_offset`
Frank Bossen
committed
`lflvl`: use slice instead of raw pointer
Frank Bossen
committed
`fn backup_lpf`: use slice instead of raw pointer for `dst`
Frank Bossen
committed
`fn filter_plane_rows_y/uv`: use slice instead of raw pointer
Frank Bossen
committed
Address comments from review
Frank Bossen
committed
Copy comments from C code
Frank Bossen
committed
Avoid unnecessary type casting when invoking `BD::pxstride`
Frank Bossen
committed
Reduce number of casts for variable `top`
Frank Bossen
committed
`fn backup_lpf`: clean up pixel copy
Frank Bossen
committed
Remove explicit dereference of `dsp`
Frank Bossen
committed
Clean up use of `split_at_mut` and pixel copy
Frank Bossen
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`mod lf_apply`: clean up code and use slices instead of raw pointers#728

`mod lf_apply`: clean up code and use slices instead of raw pointers#728
fbossen merged 26 commits intomemorysafety:mainfrom
fbossen:cleanup-lf-apply

Commits on Mar 6, 2024

`fn rav1d_copy_lpf`: use slice instead of pointer for `src_stride`

`fn rav1d_copy_lpf`: use slice instead of pointer for `lr_stride`

`fn rav1d_copy_lpf`: make `src` parameter a slice reference

`fn rav1d_loopfilter_sbrow_cols`: use slice reference instead of raw pointer

`fn rav1d_loopfilter_sbrow_cols`: clean up loops

`fn rav1d_loopfilter_sbrow_cols`: avoid repeated casts to `usize`

`fn rav1d_loopfilter_sbrow_cols`: clean up masks

Use slice instead of raw pointer

`fn rav1d_loopfilter_sbrow_cols`: make `lpf_y` and `lpf_uv` slices

Clean up types and casts

Use references to `Rav1dDSPContext` object

`fn rav1d_loopfilter_sbrow_cols`: pass slices of samples as argument

`fn filter_plane_cols_y/uv`: make `dst`/`u`/`v` arguments a slice

`lf_apply.rs`: use slices instead of raw pointers

`fn backup_lpf`; use slice as parameter

Define inner blocks for computation of `p` and `p_offset`

`lflvl`: use slice instead of raw pointer

`fn backup_lpf`: use slice instead of raw pointer for `dst`

`fn filter_plane_rows_y/uv`: use slice instead of raw pointer

Address comments from review

Copy comments from C code

Avoid unnecessary type casting when invoking `BD::pxstride`

Reduce number of casts for variable `top`

`fn backup_lpf`: clean up pixel copy

Remove explicit dereference of `dsp`

Clean up use of `split_at_mut` and pixel copy