mod lr_apply: clean up code#746
Merged
fbossen merged 15 commits intomemorysafety:mainfrom Feb 26, 2024
Merged
Conversation
kkysen
requested changes
Feb 15, 2024
fbossen
force-pushed
the
cleanup-lr-apply
branch
from
099661b to
b33b6c4
Compare
added 15 commits
February 23, 2024 06:40
Note: `dst` is now an array of pointers. Still need to make it am array of slices
Also add a `dst_offset` parameter as indexing into the original `dst` parameter could use negative offsets.
fbossen
force-pushed
the
cleanup-lr-apply
branch
from
b33b6c4 to
c4537e3
Compare
Collaborator
Same as #728 (comment); can this be "fixes" instead of "addresses"? |
Contributor
Author
I believe it can. Let me know if I missed something. |
kkysen
approved these changes
Feb 26, 2024
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #704 :
booltype where appropriate