struct Rav1dFrameContext_lf::lr_line_buf: Make into AlignedVec64#792
Merged
randomPoison merged 1 commit intomainfrom Mar 11, 2024
Merged
struct Rav1dFrameContext_lf::lr_line_buf: Make into AlignedVec64#792randomPoison merged 1 commit intomainfrom
struct Rav1dFrameContext_lf::lr_line_buf: Make into AlignedVec64#792randomPoison merged 1 commit intomainfrom
Conversation
kkysen
approved these changes
Mar 11, 2024
kkysen
changed the title
Rav1dFrameContext_lf::lr_line_buf: Make into AlignedVec64struct Rav1dFrameContext_lf::lr_line_buf: Make into AlignedVec64
kkysen
reviewed
Mar 13, 2024
Comment on lines
4449
to
4451
| if y_stride * num_lines as isize != f.lf.lr_buf_plane_sz[0] as isize | ||
| || uv_stride * num_lines as isize * 2 != f.lf.lr_buf_plane_sz[1] as isize | ||
| { |
Collaborator
There was a problem hiding this comment.
Based @fbossen's comment here, #793 (comment), it seems this if should be removed, right?
I think we can also get rid of lr_buf_plane_sz and just calculate it from f.sr_cur.p.stride, f.sbh, seq_hdr.sb128, and c.tc.len() the one time we need it later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.