Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: error detection #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: error detection #123

wants to merge 2 commits into from

Conversation

vpodzime
Copy link
Collaborator

No description provided.

@vpodzime
chore: Return MENDER_DONE when waiting for reboot in mender_client_wo…
fc863b2 
…rk_function()

This tells the scheduler that this work is done and should not be
scheduled again.

Ticket: MEN-7555
Changelog: none
Signed-off-by: Vratislav Podzimek <[email protected]>
@vpodzime
chore: Try to detect too many network issues and reset network
f446e99 
Instead of being stuck in the non-working setup.

Ticket: MEN-7555
Changelog: none
Signed-off-by: Vratislav Podzimek <[email protected]>
@vpodzime
Copy link
Collaborator Author

vpodzime commented Nov 26, 2024 •
edited
Loading

I'm putting this up for an early evaluation of the idea. Do you agree this is the right way to go? Some notes from me:

  • We could add locking, but I feel like it's not worth it because if we miss an error because of interleaving threads, it's not a big deal.
  • We could make the code platform-specific and use atomic operations, but, again, not worth it for the same reason.
  • Network issues are a good first example, what else should we try to detect?
  • Should we return MENDER_OK to the scheduler while waiting for a reboot so that we have a (better) chance to detect that the reboot is not happening and we should fail the deployment? (introducing a pending_reboot counter)
  • Should the limits be build-configurable?
  • Should this functionality be optional?

Thanks in advance for feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluiscampos lluiscampos Awaiting requested review from lluiscampos

@larsewi larsewi Awaiting requested review from larsewi

@danielskinstad danielskinstad Awaiting requested review from danielskinstad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vpodzime