Repository navigation
Harden helper responses, fix Discover UI state, and expand catalog to 254 apps - #29
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The checker needs architecture-aware repository selection, and the privileged helper changes warrant final human review.
1 open issue
What changed in this PR
This PR hardens helper communication and repository-key confirmation, fixes Discover state handling and readability, and expands the catalog from 174 to 254 applications while preserving enabled-repository filtering.
Changes:
- Isolate helper diagnostics from protocol responses and require fresh fingerprint evidence for each key prompt.
- Fix Discover navigation, essential-app actions, capped-result messaging, and status-chip contrast.
- Add 80 catalog entries, a Void repository checker, and improvements to audit tooling and test fixtures.
| File | Description |
|---|---|
| scripts/check-discover-void.py | Adds package and desktop-file verification with JSON reporting. |
| scripts/audit.sh | Resolves the repository root and limits scans to maintained Rust sources. |
| README.md | Updates the catalog count and documents the checker. |
| caerus/src/ui/style.css | Improves status-chip contrast and font weight. |
| caerus/src/ui/discover.rs | Fixes app-page state, essential-app actions, and search-limit messaging. |
| caerus/src/ui/catalog.rs | Adds 80 applications and strengthens catalog integrity checks. |
| caerus/src/ui/apply_dialog.rs | Hardens transaction-fixture directory handling and failure diagnostics. |
| caerus/src/backend/transaction.rs | Treats stderr as logs and tests protocol isolation. |
| caerus-helper/src/main.rs | Consumes fingerprints per prompt and enforces the parser’s expected locale. |
Review effort: Balanced
Co-authored-by: mendescotta <4656415+mendescotta@users.noreply.github.com>
Move 22 existing catalog apps into six new sections: Finance, Backup & security, CAD & engineering, Photography, News & podcasts, and Notes & planning, each with a themed icon and accent. When a reload removes the app being viewed, go back to the page the user came from (refilling the category page, which render() only refreshes while visible) instead of always Explore. Feed the stderr isolation test a well-formed EVENT line.
mendescotta
force-pushed
the
fix/security-ui-discover-review
branch
from
October 26, 2026 11:54
c7070b7 to
06aafff
Compare
mendescotta
added a commit
that referenced
this pull request
Oct 30, 2026
…o 19 sections (#29) Treat helper/pkexec stderr as log data and require a fresh matching fingerprint per key prompt. Fix Discover app-page state, essential-app updates, capped search results and status-chip contrast. Expand the catalog to 254 apps in 19 sections and add scripts/check-discover-void.py with architecture-aware repository selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This review hardens helper response handling and repository-key confirmation, fixes Discover UI state and status contrast, and expands Discover from 174 to 254 applications. Runtime filtering still limits the catalog to enabled repositories.
Findings addressed
OK,READY, orERRORcould advance or fail a batch. Stderr is now log data; a regression test checks queue integrity.scripts/audit.shresolves the repository root and scans maintained Rust sources only. The GTK transaction fixture uses a private newly created directory independent of umask and includes useful failure diagnostics.Catalog
The catalog now has 254 applications (80 additions across two rounds) in 19 sections. The second round was researched directly by the primary agent against Void's official x86_64 binary repository with configured third-party repositories excluded. All 44 additional apps have verified package names and desktop filenames; Audacious's desktop file was verified in its audacious-base dependency. The missing zulucrypt candidate was excluded.
New examples include GnuCash, HomeBank, KMyMoney, Pika Backup, Seahorse, Kleopatra, digiKam, Hugin, OpenSCAD, SolveSpace, CherryTree, Zim, QOwnNotes, Liferea, Akregator, RSS Guard, gPodder, Shortwave, Hydrogen, Helvum, qpwgraph and MusicBrainz Picard.
The reusable
scripts/check-discover-void.pychecker is documented in README and supports--desktop-filesand JSON output. Its valid, missing and invalid-name cases were exercised, and every newly added catalog desktop ID was cross-checked against official binary file lists.Sections
Six sections were added (13 → 19) by moving existing apps; no catalog entries changed:
The grid stays 4 columns (2 narrow); sections with no available apps are hidden.
The requested cheaper agent researched 36 additions spanning GNOME and other desktops: Polari, Gnote, Loupe, GNOME games/tools, Sylpheed, ghostwriter, nomacs, Mixxx, QjackCtl, Kodi, Kamoso, Marble, LabPlot, KDevelop, KDE Connect, KRDC, KTorrent, Tellico and Ark. Integrity checks now cover display names and desktop IDs as well as package aliases.
Official Void sources include GNOME, Mixxx, KDevelop, Kodi, KDE Connect, and Sylpheed. Availability depends on architecture and enabled repositories.
Review follow-up
check-discover-void.pyselects the Void repository from the effective XBPS architecture (aarch64 →/current/aarch64, other musl →/current/musl), per Copilot review.EVENT 1line.Validation
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test: 72 application tests and 25 helper tests pass; GTK test run separately.cargo build --features adwaitacargo test -p caerus --no-default-features --features apk,adwaita: 74 pass.cargo clippy -p caerus --all-targets --no-default-features --features apk,adwaita -- -D warningsbash scripts/audit.sh, shell syntax and diff whitespace checks.--ignored) passes with cached real repository inventory, reload, Discover sections/category/app pages, wide/narrow layout and an unprivileged transaction fixture. Screenshots inspected locally under/tmp/caerus-quality-review. Final captures use Cairo, matching normal startup.Initial ownership-test failures came from sandbox UID remapping; these pass outside the sandbox. The smoke test exposed and now fixes an umask-dependent fixture. GTK still emits color-scheme deprecation and layout measurement warnings in the cached-inventory test; assertions and rendering pass. No live privileged package mutation or key import was performed. This focused review does not claim exhaustive fuzzing or dependency-vulnerability coverage.