Skip to content

Harden helper responses, fix Discover UI state, and expand catalog to 254 apps - #29

Merged
mendescotta merged 5 commits into
mainfrom
fix/security-ui-discover-review
Oct 26, 2026
Merged

mendescotta merged 5 commits into
mainfrom
fix/security-ui-discover-review

Conversation

@mendescotta

@mendescotta mendescotta commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

This review hardens helper response handling and repository-key confirmation, fixes Discover UI state and status contrast, and expands Discover from 174 to 254 applications. Runtime filtering still limits the catalog to enabled repositories.

Findings addressed

  • Protocol isolation: helper/pkexec stderr was treated as protocol. Diagnostics resembling OK, READY, or ERROR could advance or fail a batch. Stderr is now log data; a regression test checks queue integrity.
  • Key-confirmation hardening: a fingerprint remained valid after a prompt. Consume it per prompt so subsequent prompts require fresh matching evidence; use the C locale expected by the parser. Defense in depth, with no privilege-escalation exploit claimed.
  • Discover correctness: allow updates of essential apps while blocking removal; leave stale app pages after repository refresh (returning to the originating page, refreshing a category page); prevent late confirmations from replacing another app's details; explain capped search results.
  • UI consistency: theme foreground text and semantic background tints keep status chips readable across package details and Discover, including the local dark theme.
  • Review tooling: scripts/audit.sh resolves the repository root and scans maintained Rust sources only. The GTK transaction fixture uses a private newly created directory independent of umask and includes useful failure diagnostics.

Catalog

The catalog now has 254 applications (80 additions across two rounds) in 19 sections. The second round was researched directly by the primary agent against Void's official x86_64 binary repository with configured third-party repositories excluded. All 44 additional apps have verified package names and desktop filenames; Audacious's desktop file was verified in its audacious-base dependency. The missing zulucrypt candidate was excluded.

New examples include GnuCash, HomeBank, KMyMoney, Pika Backup, Seahorse, Kleopatra, digiKam, Hugin, OpenSCAD, SolveSpace, CherryTree, Zim, QOwnNotes, Liferea, Akregator, RSS Guard, gPodder, Shortwave, Hydrogen, Helvum, qpwgraph and MusicBrainz Picard.

The reusable scripts/check-discover-void.py checker is documented in README and supports --desktop-files and JSON output. Its valid, missing and invalid-name cases were exercised, and every newly added catalog desktop ID was cross-checked against official binary file lists.

Sections

Six sections were added (13 → 19) by moving existing apps; no catalog entries changed:

Section Apps
Finance GnuCash, HomeBank, KMyMoney
Backup & security Pika Backup, KeePassXC, Kleopatra
CAD & engineering FreeCAD, KiCad, OpenSCAD, SolveSpace
Photography digiKam, Hugin, Darktable
News & podcasts Liferea, Akregator, gPodder
Notes & planning CherryTree, Zim, QOwnNotes, KOrganizer

The grid stays 4 columns (2 narrow); sections with no available apps are hidden.

The requested cheaper agent researched 36 additions spanning GNOME and other desktops: Polari, Gnote, Loupe, GNOME games/tools, Sylpheed, ghostwriter, nomacs, Mixxx, QjackCtl, Kodi, Kamoso, Marble, LabPlot, KDevelop, KDE Connect, KRDC, KTorrent, Tellico and Ark. Integrity checks now cover display names and desktop IDs as well as package aliases.

Official Void sources include GNOME, Mixxx, KDevelop, Kodi, KDE Connect, and Sylpheed. Availability depends on architecture and enabled repositories.

Review follow-up

  • check-discover-void.py selects the Void repository from the effective XBPS architecture (aarch64 → /current/aarch64, other musl → /current/musl), per Copilot review.
  • The stderr-isolation test now uses a well-formed EVENT 1 line.

Validation

  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test: 72 application tests and 25 helper tests pass; GTK test run separately.
  • cargo build --features adwaita
  • cargo test -p caerus --no-default-features --features apk,adwaita: 74 pass.
  • cargo clippy -p caerus --all-targets --no-default-features --features apk,adwaita -- -D warnings
  • bash scripts/audit.sh, shell syntax and diff whitespace checks.
  • GTK smoke test (--ignored) passes with cached real repository inventory, reload, Discover sections/category/app pages, wide/narrow layout and an unprivileged transaction fixture. Screenshots inspected locally under /tmp/caerus-quality-review. Final captures use Cairo, matching normal startup.

Initial ownership-test failures came from sandbox UID remapping; these pass outside the sandbox. The smoke test exposed and now fixes an umask-dependent fixture. GTK still emits color-scheme deprecation and layout measurement warnings in the cached-inventory test; assertions and rendering pass. No live privileged package mutation or key import was performed. This focused review does not claim exhaustive fuzzing or dependency-vulnerability coverage.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:26
@mendescotta mendescotta changed the title Harden helper responses, fix Discover UI state, and expand catalog to 210 apps Harden helper responses, fix Discover UI state, and expand catalog to 254 apps Oct 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The checker needs architecture-aware repository selection, and the privileged helper changes warrant final human review.

1 open issue
What changed in this PR

This PR hardens helper communication and repository-key confirmation, fixes Discover state handling and readability, and expands the catalog from 174 to 254 applications while preserving enabled-repository filtering.

Changes:

  • Isolate helper diagnostics from protocol responses and require fresh fingerprint evidence for each key prompt.
  • Fix Discover navigation, essential-app actions, capped-result messaging, and status-chip contrast.
  • Add 80 catalog entries, a Void repository checker, and improvements to audit tooling and test fixtures.
File Description
scripts/​check-discover-void.py Adds package and desktop-file verification with JSON reporting.
scripts/​audit.sh Resolves the repository root and limits scans to maintained Rust sources.
README.md Updates the catalog count and documents the checker.
caerus/​src/​ui/​style.css Improves status-chip contrast and font weight.
caerus/​src/​ui/​discover.rs Fixes app-page state, essential-app actions, and search-limit messaging.
caerus/​src/​ui/​catalog.rs Adds 80 applications and strengthens catalog integrity checks.
caerus/​src/​ui/​apply_dialog.rs Hardens transaction-fixture directory handling and failure diagnostics.
caerus/​src/​backend/​transaction.rs Treats stderr as logs and tests protocol isolation.
caerus-helper/​src/​main.rs Consumes fingerprints per prompt and enforces the parser’s expected locale.

Review effort: Balanced

Comment thread scripts/check-discover-void.py Resolved
Co-authored-by: mendescotta <4656415+mendescotta@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Privileged helper communication and key-import confirmation changes warrant human validation beyond the supplied unit and smoke tests.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Move 22 existing catalog apps into six new sections: Finance, Backup &
security, CAD & engineering, Photography, News & podcasts, and Notes &
planning, each with a themed icon and accent.

When a reload removes the app being viewed, go back to the page the user
came from (refilling the category page, which render() only refreshes
while visible) instead of always Explore. Feed the stderr isolation test
a well-formed EVENT line.
@mendescotta
mendescotta force-pushed the fix/security-ui-discover-review branch from c7070b7 to 06aafff Compare October 26, 2026 11:54
@mendescotta
mendescotta merged commit e643058 into main Oct 26, 2026
2 checks passed
@mendescotta
mendescotta deleted the fix/security-ui-discover-review branch October 26, 2026 12:04
mendescotta added a commit that referenced this pull request Oct 30, 2026
…o 19 sections (#29)

Treat helper/pkexec stderr as log data and require a fresh matching fingerprint per key prompt. Fix Discover app-page state, essential-app updates, capped search results and status-chip contrast. Expand the catalog to 254 apps in 19 sections and add scripts/check-discover-void.py with architecture-aware repository selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants