Repository navigation
Fix stale state, sync races and review nits from ultrareview - #30
Merged
Merged
Conversation
- Re-read the inspected package after every reload so the details pane never offers actions for a package that changed or disappeared. - Treat a repository SYNC as busy: Apply, reinstall, upgrade, force-remove and one-off helper commands wait for it instead of previewing against the index it is replacing. Blocked commands explain why. - Force-remove reports a failed reverse-dependency check as unknown rather than "no other installed package depends on it". - Startup tracing ignores stderr write errors and skips its list walk and frame callback when disabled. - Column choices made while narrow survive widening; never hold the saved-columns borrow across set_visible. - install.sh --uninstall accepts an older absolute PREFIX (still rejecting relative and dot paths); installs still require /usr. - Discover refreshes marks only for catalog apps and only re-renders when one changed; an app-page action refills the page once. - Drop dead set_ellipsize calls in the sidebar.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
mendescotta
added a commit
that referenced
this pull request
Oct 30, 2026
* Fix stale state, sync races and review nits from ultrareview - Re-read the inspected package after every reload so the details pane never offers actions for a package that changed or disappeared. - Treat a repository SYNC as busy: Apply, reinstall, upgrade, force-remove and one-off helper commands wait for it instead of previewing against the index it is replacing. Blocked commands explain why. - Force-remove reports a failed reverse-dependency check as unknown rather than "no other installed package depends on it". - Startup tracing ignores stderr write errors and skips its list walk and frame callback when disabled. - Column choices made while narrow survive widening; never hold the saved-columns borrow across set_visible. - install.sh --uninstall accepts an older absolute PREFIX (still rejecting relative and dot paths); installs still require /usr. - Discover refreshes marks only for catalog apps and only re-renders when one changed; an app-page action refills the page once. - Drop dead set_ellipsize calls in the sidebar. * Configure GitHub security checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 2 bugs and 7 nits from an ultrareview of
d1d5bb8..main.Bugs
syncingflag now joinsaction_busy/is_loadingin oneactions_blockedguard used by Apply, reinstall, full upgrade, force-remove andrun_maintenance_command(the choke point for every one-off helper command). Blocked commands show a toast. Marks stay editable.Nits
tracewrites withwriteln!and ignores errors, so a closed stderr cannot panic a reload; costly trace arguments and the frame callback run only when tracing is enabled.RefCellis no longer borrowed acrossset_visible, whose two-way binding fires the toggle handler synchronously.install.sh --uninstall: accepts an older absolute PREFIX so a previous/usr/localinstall can be removed; relative and./..paths are still refused, and installs still require/usr. README notes it.states_and_marks_ofin both backends), and cards/app page re-render only when a catalog app actually changed. An app-page action refills the page once.set_ellipsizecalls; the effective mode at each site is unchanged.Validation
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test--features adwaita; clippy and tests with--no-default-features --features apk--ignored --test-threads=1), extended with narrow-mode column casesscripts/audit.sh;scripts/test-install-prefix.py(new uninstall cases),test-user-install.py,test-release-lookup.pyNew unit tests cover force-remove heading wording and Discover change detection. The details-pane refresh and sync gating are window wiring without automated coverage.