[UFC-1757] Remove deprecated PWA meta tag for login.html #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
On navigation to
login.htmlin apps using the Atlas theme the following deprecation warning message is shown in the dev tools console:This deprecated meta tag was used for Apple devices which used to not have proper support for the web app manifest. However, as of iOS 11.3, proper support for it was added, making this meta tag redundant.
I tested the change on my iPhone and I am still able to add a PWA to my homescreen in fullscreen mode.
This MR removes the tag for
login.htmlandlogin-with-mendixsso-button.htmlto get rid of the warning.