[MOO-1126]: TakePicture function in NativeMobileResources presentatio…

…nStyle changed (#69)
mendix · Aug 22, 2023 · fce59a1 · fce59a1
2 parents e65fd32 + 1c08b66
commit fce59a1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/packages/jsActions/mobile-resources-native/CHANGELOG.md b/packages/jsActions/mobile-resources-native/CHANGELOG.md
@@ -6,10 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
-## [5.0.1] Native Mobile Resources - 2023-7-31
+### Fixed
 
+-   We updated the default presentation mode for both "Take Picture" and "Take Picture Advanced" to full screen.
+
+## [5.0.1] Native Mobile Resources - 2023-7-31
 
 ## [3.0.2] BarChart
+
 ### Fixed
 
 -   We fixed an issue when running with Mx10 crashes the app.

diff --git a/packages/jsActions/mobile-resources-native/src/camera/TakePicture.ts b/packages/jsActions/mobile-resources-native/src/camera/TakePicture.ts
@@ -77,7 +77,7 @@ export async function TakePicture(
 
     function takePicture(): Promise<string | undefined> {
         return new Promise((resolve, reject) => {
-            const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptionsV4();
+            const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptions();
             getPictureMethod()
                 .then(method =>
                     method(options, (response: ImagePickerV2Response | ImagePickerResponse) => {
@@ -241,9 +241,10 @@ export async function TakePicture(
         };
     }
 
-    function getOptionsV4(): CameraOptions | ImageLibraryOptions {
+    function getOptions(): CameraOptions | ImageLibraryOptions {
         const { maxWidth, maxHeight } = getPictureQuality();
         return {
+            presentationStyle: "fullScreen",
             mediaType: "photo" as const,
             maxWidth,
             maxHeight

diff --git a/packages/jsActions/mobile-resources-native/src/camera/TakePictureAdvanced.ts b/packages/jsActions/mobile-resources-native/src/camera/TakePictureAdvanced.ts
@@ -130,7 +130,7 @@ export async function TakePictureAdvanced(
 
     function takePicture(): Promise<ImagePickerV2Response | ImagePickerResponse | undefined> {
         return new Promise((resolve, reject) => {
-            const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptionsV4();
+            const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptions();
             getPictureMethod()
                 .then(method =>
                     method(options, (response: ImagePickerV2Response | ImagePickerResponse) => {
@@ -294,9 +294,10 @@ export async function TakePictureAdvanced(
         };
     }
 
-    function getOptionsV4(): CameraOptions | ImageLibraryOptions {
+    function getOptions(): CameraOptions | ImageLibraryOptions {
         const { maxWidth, maxHeight } = getPictureQuality();
         return {
+            presentationStyle: "fullScreen",
             mediaType: "photo" as const,
             maxWidth,
             maxHeight