Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1123]: rename base64encode parameter name #122

Merged

Conversation

Ahmad-Elsayed
Copy link
Contributor

@Ahmad-Elsayed Ahmad-Elsayed commented Mar 15, 2024

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 10
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

...

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

...

Extra comments (optional)

Please add extra comments or delete the section if not required

@Ahmad-Elsayed Ahmad-Elsayed requested a review from a team as a code owner March 15, 2024 13:49
@Ahmad-Elsayed Ahmad-Elsayed force-pushed the moo/MOO-1123-module-nanoflow-commons-cw-9503-warning branch from ff85ce4 to 0cb2dbd Compare March 15, 2024 13:56
@stelselim
Copy link
Contributor

LGTM

@Ahmad-Elsayed Ahmad-Elsayed merged commit 7758533 into main Mar 15, 2024
18 of 19 checks passed
@Ahmad-Elsayed Ahmad-Elsayed deleted the moo/MOO-1123-module-nanoflow-commons-cw-9503-warning branch March 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants