Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOO-803] fix: update react native video to latest version #165

Closed
wants to merge 2 commits into from
Closed

[MOO-803] fix: update react native video to latest version #165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
431e6e2
fix: update react native video to latest version
karahanharunn Aug 23, 2024
bcc1758
chore: updating changelogs
karahanharunn Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/video-player-native/package.json
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the release notes https://github.com/mendix/native-widgets/pull/128/files#diff-f5f12795dbd3289597dea2779bb9fa80488c26fe56f6e5106abc9fd186acc1ef

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "video-player-native",
"widgetName": "VideoPlayer",
"version": "5.0.0",
"version": "5.0.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand All @@ -23,7 +23,7 @@
"deprecated-react-native-prop-types": "^4.0.0",
"react-native-system-navigation-bar": "2.6.3",
"react-native-vector-icons": "10.0.3",
"react-native-video": "5.2.1"
"react-native-video": "6.4.5"
},
"devDependencies": {
"@mendix/piw-utils-internal": "1.0.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
Modal,
NativeModules
} from "react-native";
import Video, { OnProgressData, VideoProperties } from "react-native-video";
import Video, { OnProgressData, ReactVideoProps, VideoRef } from "react-native-video";
import Icon from "react-native-vector-icons/MaterialIcons";
import { VideoPlayerProps } from "../typings/VideoPlayerProps";
import { defaultVideoStyle, VideoStyle } from "./ui/Styles";
Expand All @@ -29,8 +29,8 @@ const enum StatusEnum {
export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
const [styles, setStyles] = useState(flattenStyles(defaultVideoStyle, props.style));
const timeoutRef = useRef<NodeJS.Timeout>();
const playerRef = useRef<Video>(null);
const fullScreenPlayerRef = useRef<Video>(null);
const playerRef = useRef<VideoRef>(null);
const fullScreenPlayerRef = useRef<VideoRef>(null);
const [status, setStatus] = useState(StatusEnum.NOT_READY);
const [videoAspectRatio, setVideoAspectRatio] = useState(0);
const [fullScreen, setFullScreen] = useState(false);
Expand Down Expand Up @@ -100,7 +100,7 @@ export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
}
}

const videoProps: VideoProperties = {
const videoProps: ReactVideoProps = {
testID: props.name,
source: { uri: isAvailable(props.videoUrl) ? props.videoUrl.value : undefined },
muted: props.muted,
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/video-player-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="VideoPlayer" version="5.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="VideoPlayer" version="5.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="VideoPlayer.xml" />
</widgetFiles>
Expand Down
Loading