[MOO-809]: Implement a11y for pluggable widgets #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrazAkgultan
force-pushed
the
feat/accessibility
branch
from
23d72ce
to
3109960
Compare
UrazAkgultan
force-pushed
the
feat/accessibility
branch
from
3109960
to
3d406f4
Compare
| return visible ? ( | ||
| <View style={style.container}> | ||
| <Pressable | ||
| style={[style.header.container, icon === "left" && { flexDirection: "row-reverse" }]} | ||
| onPress={collapsible ? () => onPressGroupHeader(group, index) : null} | ||
| accessible={isAccessible} |
There was a problem hiding this comment.
I am not sure if this is the right place to configure if the element is accessible or not, as if the accordion element is open by default then the children will be accessible still.
| (group.headerRenderMode === "text" ? group.headerText.value : undefined) | ||
| } | ||
| accessibilityHint={group.screenReaderHint?.value} | ||
| accessibilityState={{ expanded: isExpanded }} |
There was a problem hiding this comment.
you can use accessibilityElementsHidden and importantForAccessibility properties to disable all the children if the parent is disabled
| @@ -41,11 +48,12 @@ export function GroupIcon({ iconCollapsed, iconExpanded, isExpanded, style }: Gr | |||
| }, [isExpanded, animatedValue]); | |||
|
|
|||
| return customIconsConfigured ? ( | |||
| <View style={iconStyles}> | |||
| <View accessible={accessible} style={iconStyles}> | |||
There was a problem hiding this comment.
it would be nice if there is a caption for the icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
Implement a11y for pluggable widgets.