[WC-2868] add number filter linked datasource #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
reviewed
Apr 2, 2025
| } | ||
|
|
||
| hidePropertyIn(defaultProperties, {} as { linkedDs: unknown }, "linkedDs"); |
There was a problem hiding this comment.
TODO: check if this is really needed, it should be either hidden by default so we don't have to do it, or the preview typings have to exposed by PWT.
There was a problem hiding this comment.
Or let it be shown, as a reference to the user, it is not configurable anyways.
r0b1n
reviewed
Apr 2, 2025
Comment on lines
+60
to
+61
| format: v => v ?? "", | ||
| parse: v => ({ valid: true, value: v ?? "" }) |
There was a problem hiding this comment.
I would expect this not to be enough for Big, as it has to do at least some formatting to string and back 🤔 .
iobuhov
force-pushed
the
data-widgets-v3.0
branch
from
6c2e818 to
c525280
Compare
iobuhov
force-pushed
the
WC-2868-number-wide-filter
branch
from
100587c to
4072abe
Compare
iobuhov
changed the base branch from
data-widgets-v3.0
to
WC2869-improved-filtering-date-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description