[WC-3027] Add Multi-Page Select All functionality to Datagrid #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
wc-3027_dg2_multipage_selectall
branch
2 times, most recently
from
979dd4f to
688c166
Compare
iobuhov
force-pushed
the
wc-3027_dg2_multipage_selectall
branch
3 times, most recently
from
cdee2cf to
253d090
Compare
iobuhov
force-pushed
the
wc-3027_dg2_multipage_selectall
branch
from
a72742a to
692515b
Compare
r0b1n
reviewed
Oct 16, 2025
| type SpinnerLoaderProps = { | ||
| size?: "small" | "medium" | "large"; | ||
| withMargins?: boolean; | ||
| fullWidth?: boolean; |
There was a problem hiding this comment.
Looks like we never use this prop anywhere
r0b1n
reviewed
Oct 16, 2025
| } | ||
|
|
||
| #{$root}-clear-selection { | ||
| #{$root}-btn-invisible { |
There was a problem hiding this comment.
It is not really invisible, it makes them look like a link, I would call it btn-link or something.
r0b1n
reviewed
Oct 16, 2025
|
|
||
| function Checkbox(props: { status: SelectionStatus; onChange: () => void; "aria-label"?: string }): React.ReactNode { | ||
| if (props.status === "unknown") { | ||
| console.error("Data grid 2: don't know how to render column checkbox with selectionStatus=unknown"); |
There was a problem hiding this comment.
In which scenario this happens?
r0b1n
reviewed
Oct 16, 2025
| import { createElement } from "react"; | ||
| import { useDatagridRootScope } from "../helpers/root-context"; | ||
|
|
||
| export const SelectAllBar = observer(function SelectAllBar(): React.ReactNode { |
There was a problem hiding this comment.
Import ReactNode from "react". We disallowed global React.* namespace in out React 19 migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
This PR implements multi-page select all functionality for the Datagrid2 widget, allowing users to select all items across multiple pages based on the current filter. The feature includes configurable batch processing, progress tracking, and cancellation support, similar to the existing Excel export functionality.
What should be covered while testing?
Small dataset (< buffer size): Should use immediate selection
Large dataset (>= buffer size): Should show progress dialog and batch processing
Unknown total count: Should fall back to per-page selection
Cancellation: Should properly cancel and restore state
Page restoration: Should return user to original page after selection
Filtered data: Should only select items matching current filter